fix: Fix LazyServiceFactory to handle exception in constructor #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if it's possible, please create a patch release for the 3 version with this fix |
idsulik
force-pushed
the
fix-lazyservicefactory
branch
2 times, most recently
from
0edf3b9 to
6523add
Compare
Signed-off-by: Suleiman Dibirov <[email protected]>
idsulik
force-pushed
the
fix-lazyservicefactory
branch
from
6523add to
3cd80a2
Compare
vdmorozov
reviewed
Dec 11, 2024
|
@vdmorozov will create a separate PR |
|
Here: #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where exceptions thrown during lazy service initialization would leave the proxy in an invalid state. The fix ensures that the original initializer is restored when an exception occurs, allowing subsequent initialization attempts to work correctly.
Added tests to verify the behavior.
p.s. thanks to @vdmorozov, he found the issue